Refueling with Jerry can problems. Trigger not attaching to vehicle.

[Allanp]

I think we've nearly got this perfected. I played around with it a bit more and I really didn't like how Attach Options was still available and it would activate case 0 of attachtruck.sqf so I made it a seperate .sqf.
Posting all the code for anyone who wants to try this out,modify it or perfect it.

Spoiler:

show spoiler

AttachOption

//int for jerrycan 
//take=0;  act1 = this addaction ["Take Fuel Can","carry.sqf",[0],1,false,true,"","player distance scase < 2"];
//act3 = this addaction ["Refuel truck","fill.sqf","",1,false,true,"","scase distance truck_start <= 5  and player distance truck_start <= 5 and take==0"]; 
//act4 = this addaction ["Attach Options","attachoption.sqf",[1],1,false,true,"","player distance truck_start < 4 and player distance scase < 4  and take==0"]; 

titleText ["Seems like you can attach this to the Truck","PLAIN"]; //Initial message when player chooses Attach Option on addaction menu

scase removeaction act4; //Removes Attach Option from addaction menu

sleep 2; 

titleText ["You figured out how to attach it.","PLAIN"]; // Joyest Message given to player

sleep 3; 

[]execVM "attachtruck.sqf"; // executes attachment to truck 

Attach Truck

//Script created with major help from  F2k Sel
//act3 = truck_start addaction ["Refuel truck","fill.sqf","",1,false,true,"","scase distance truck_start <= 5  and player distance truck_start <= 5 and take==0"]; 
//act2 = truck_start addaction ["Attach Options","attachtruck.sqf",[1],1,false,true,"","player distance truck_start < 4 and player distance scase < 4  and take==0"]; 
// (These inits I placed on the Jerry Can instead of the Truck, not sure if it changes the effectiveness of the script, check AttachOption.sqf for full attachment on Jerry Can)


player removeAction act1;
truck_start removeAction act2;// remove initial action on truck.
_man = player;

//Fasten jerry can to back of truck 
switch (take) do
{
   case 0:
    {
      detach scase;
       titleText ["Fastening Jerry Can to Truck","PLAIN"]; 
        player removeAction act2;
        scase removeaction act1;
         sleep 5;
          scase attachTo [truck_start,[-0.9,-3.1875,-0.5]]; // attach to vehicle
           titleText ["Jerry Can is secured","PLAIN"];          
             act2 = scase addaction ["Remove from Truck","attachtruck.sqf","",1,false,true,"","player distance scase < 4"];//change action for next case 
              take=1;
    };  
    
  //Attach Jerry Can to hip after removing jerry can from back of truck     
 
   case 1:
    {
     detach scase;
       titleText ["Unfastening Fuel Can","PLAIN"]; 
         sleep 5;
          scase removeAction act2;
            scase setvelocity[0,0,-.3];
         // scase attachto [_man, [-0.23,0,-0.15],"Pelvis"]; // attach to player
         //  scase setdir 75;           
             act2 = _man addaction ["Attach to back of Truck","attachtruck.sqf","",1,false,true,"","player distance truck_start < 5 and scase distance truck_start < 5 and take==0"];
             act1 = scase addaction ["Take Jerry Can","carry.sqf","",1,false,true,""];
               take=0;
    }; 
}; 

Carry

//////////////////////////////////////////////////////////////////
// Function file for Armed Assault
// Created by: TODO: Author Name
//////////////////////////////////////////////////////////////////

//Script pulled from  F2k Sel
//init: take=0;  act1 = this addaction ["Take Fuel Can","carry.sqf",[0],1,false,true,"","player distance scase < 2"]  
//Jerry Can starts at case 0 so first the player can pick it up

switch (take) do
{
    //pick up jerry can
    case 0:
    {
     _scase = _this select 0;
      _man = _this select 1;
    _scase attachto [_man, [-0.23,0,-0.15],"Pelvis"];
      _scase setdir 75;
      _scase removeAction act1;
       act1 = _man addaction ["Drop Jerry Can","carry.sqf","",1,false,true,""];
       take=1;scase = _scase;taken=true;
    }; 

    case 1:
    {
       _man = _this select 0;
        detach scase;
        scase setvelocity[0,0,-.3];
       _man removeAction act1;
        act1 = scase addaction ["Take Jerry Can","carry.sqf","",1,false,true,""];
        take=0;
    };
}; 

Fill

//////////////////////////////////////////////////////////////////
// Function file for Armed Assault
// Created by: TODO: Author Name
//////////////////////////////////////////////////////////////////

//Script created with major help from  F2k Sel

titleText ["Refueling","PLAIN"]; 

truck_start removeaction (_this select 2); 

sleep 10; 

truck_start setfuel 0.3; 

titleText ["Truck refueled","PLAIN"]; 

[F2k Sel]

How do you want the attach to truck to work?

Other things that really need fixing are :-

When you die you need to release the can, I had that working and needs putting back.
When you get in a truck while carrying item it sticks out the window. I see two solutions, Auto drop item or try and prevent entry while carrying.
Set variable for full and empty can.
Script need placing in one folder, minor path change.

[Allanp]

Allo F2k Sel,

After testing it out and having a few runs with a couple of buddies ( I know the code isn't for multiplayer, I just needed a few lab mice to see where an ideal spot was to place the jerry can), they seemed confused on how to attach it (drop and look)I might switch back so that the actions appear on the truck. (I could easily pop in a hint that tells the player to look at the can for more options when near the vehicle).

Edit: I'll keep with the actions on the truck but you have to drop the can. I like this approach.
Edit2: I've added sounds for fueling and attaching to truck that my friend made for me, I'll have to wait till he is online for the dropping sound.

From the things that need fixing

1. Will definitely put that back in.
2. I was thinking about that yesterday, I think a force disembark or eject with a prompt or hint (something witty like "You struggle to get in") would work perfectly
3. I was writing a mini abstraction for that early today. I was trying to figure out if there is a way to have a global variable and then call to check it in another function.
What I had planned was a trigger would be set near a fuel pump, the player would go to the fuel pump with the jerry can, drop it and be able to fill it (I'll pop an animation in)
The amount of fuel (fuelAmount) would be random (between 0.1-1.0) in the fuel pump and would be added to an int var on the Jerry Can (jerryfuelAmount).
I would have a statement to check if it would be over 1.0 and it would set jerryfuelAmount to 1. I also had plans so that the player could check how much fuel was in the jerry can
via nested loops (quarter,half,three thirds and full).
4. Cheers for reminding me about that! I'll get on that right away.

[F2k Sel]

Had a big problem today, when I added the killed eventhandler I kept getting multiple actions. I t took forever to sort it out but seems to be working.
I've also added a kick out from vehicle if carrying can.
I used calls for these as I needed to learn how to use them and it saves adding more scripts or adding them to the case statement.

It's better to use setvariable and getvariable. ie

scase setvariable ["fuel",10,true];
hint format ["Jerry Can Has %1 Liters of Fuel",scase getvariable "fuel"];

Spoiler:

show spoiler

//Script pulled from  F2k Sel
//init: take=0;  act1 = this addaction ["Take Fuel Can","carry.sqf",[0],1,false,true,"","player distance scase < 2"]  
//Jerry Can starts at case 0 so first the player can pick it up

private ["_In_out","_man"];



////////////// checks for player in or out of car  ////////////////
_in_car = {
_In_out = createTrigger["emptyDetector",[0,0,0]];
_In_out setTriggerArea [0,0,0,false]; 
_In_out setTriggerActivation ["any","present",True]; 
//_In_out setTriggerStatements["(vehicle player) != player and take == 1",";scase hideobject true;","scase hideobject false;"];// hides object
_In_out setTriggerStatements["(vehicle player) != player and take == 1","player action ['getout',nearestObject [player,'car']]; Hint 'Get out you idiot!';",""];// kicks you out if carrying
 _return
};



////////// checks if player is dead ///////////////////
_evh_Killed = {
    _man removeeventHandler ["killed",0];
    _man addEventHandler ["killed", {
    detach scase;hint "dead";
    scase removeAction act1;
    act1 = scase addaction ["Take Jerry Can","carry.sqf","",1,false,true,""];
     take=0;(_this select 0) removeeventHandler ["killed",0];  } ];
               _return
      };

switch (take) do
{
    //pick up jerry can
    case 0:
    {
     _scase = _this select 0;
      _man = _this select 1;
    _scase attachto [_man, [-0.23,0,-0.15],"Pelvis"];
      _scase setdir 75;
      _scase removeAction act1;
       act1 = _man addaction ["Drop Jerry Can","carry.sqf","",1,false,true,""];
       take=1;scase = _scase;_man call _in_car; _man call _evh_Killed;
       hint format ["Jerry Can Has %1  Liters of Fuel",scase getvariable "fuel"];
       }; 

    case 1:
    {
       _man = _this select 0;
        detach scase;
        scase setvelocity[0,0,-.3];
       _man removeAction act1;
        act1 = scase addaction ["Take Jerry Can","carry.sqf","",1,false,true,""];
        take=0;deletevehicle _In_out;
         _man removeeventHandler ["killed",0];
             
    };
}; 

Place this in the fuel cans init, you can adjust amount of fuel if you wish. It's not pretty but it worked.
scase setvariable ["fuel",10,true];

Spoiler:

show spoiler

//Script created with major help from  F2k Sel


_fuel = scase getvariable "fuel";


if (_fuel == 0)  exitwith {Hint "Your can is empty"};

titleText ["Refueling","PLAIN"]; 

truck_start removeaction (_this select 2); 

while {sleep 0.3 ; _fuel >0 } do {
_fuel=_fuel-0.3;
if (_fuel < 0) then {_fuel=0};

    
hint format ["Jerry Can Has %1  Liters of Fuel",_fuel];


};

scase setvariable ["fuel",_fuel,true];

truck_start setfuel 0.3; 

titleText ["Truck refueled","PLAIN"]; 

[Allanp]

Cheers F2k Sel!

I got a chance to play with it some more. I changed it so the value put on fuel will determine how full the truck will be. The only problem I have now is in carry (the changes I made) where it still states the Jerry Can as being full, would I have to merge them so that the value is constant or is there a way to call that var from another script? I also found a problem, when I attach the can to the truck and try to enter it kicks me out. but if I detach it from the truck and enter it lets me in.
As always, your help is greatly appreciated.

Spoiler:

show spoiler

Carry

//Script pulled from  F2k Sel
//init: take=0;  act1 = this addaction ["Take Fuel Can","carry.sqf",[0],1,false,true,"","player distance scase < 2"]  
//Jerry Can starts at case 0 so first the player can pick it up

private ["_In_out","_man"];



////////////// checks for player in or out of car  ////////////////
_in_car = {
_In_out = createTrigger["emptyDetector",[0,0,0]];
_In_out setTriggerArea [0,0,0,false]; 
_In_out setTriggerActivation ["any","present",True]; 
//_In_out setTriggerStatements["(vehicle player) != player and take == 1",";scase hideobject true;","scase hideobject false;"];// hides object
_In_out setTriggerStatements["(vehicle player) != player and take == 1","player action ['getout',nearestObject [player,'car']]; Hint 'Get out you idiot!';",""];// kicks you out if carrying
 _return
};



////////// checks if player is dead ///////////////////
_evh_Killed = {
    _man removeeventHandler ["killed",0];
    _man addEventHandler ["killed", {
    detach scase;hint "dead";
    scase removeAction act1;
    act1 = scase addaction ["Take Jerry Can","scripts\take_fill_attach\carry.sqf","",1,false,true,""];
     take=0;(_this select 0) removeeventHandler ["killed",0];  } ];
      _return
      };

switch (take) do
{
    //pick up jerry can
    case 0:
    {
     _scase = _this select 0;
      _man = _this select 1;
      _fuel = scase getvariable "fuel";
      _fuelCount = _fuel;
    if (_fuel >=1) then {_fuelCount=10; _fuel=10; titleText ["This feels full","PLAIN"]};
    if (_fuel > 0 and _fuelCount < 1) then {_fuelCount=_fuel*10};
        if (_fuelCount > 5 and _fuelCount < 10) then {titleText ["This  feels somewhat full","PLAIN"]};
        if (_fuelCount >=3 and _fuelCount < 5 ) then {titleText ["This feels half way full","PLAIN"]};
        if (_fuelCount >=1 and _fuelCount < 3 ) then {titleText ["This feels close to empty","PLAIN"]};
        if (_fuel == 0) then {titleText ["This feels empty","PLAIN"]};
      _scase attachto [_man, [-0.23,0,-0.15],"Pelvis"];
      _scase setdir 75;
      _scase removeAction act1;
       act1 = _man addaction ["Drop Jerry Can","scripts\take_fill_attach\carry.sqf","",1,false,true,""];
       take=1;scase = _scase;_man call _in_car; _man call _evh_Killed;
       hintSilent format ["Jerry Can Has %1  Liters of Fuel",_fuelCount];
       }; 

    case 1:
    {
       _man = _this select 0;
        detach scase;
        scase setvelocity[0,0,-.3];
       _man removeAction act1;
        act1 = scase addaction ["Take Jerry Can","scripts\take_fill_attach\carry.sqf","",1,false,true,""];
        take=0;deletevehicle _In_out;
         _man removeeventHandler ["killed",0];
             
    };
}; 

Fill

//Script created with major help from  F2k Sel


_fuel = scase getvariable "fuel";
_fuelCount = _fuel;

if (_fuel >=1) then {_fuelCount=10; _fuel=10};
if (_fuel > 0 and _fuel < 1) then {_fuelCount=_fuel*10};
if (_fuel == 0) exitwith {Hint "Your can is empty"};
_rest = 10-_fuelCount;

titleText ["Refueling","PLAIN"]; 

scase say ["Candecant",5]; // sound for fueling truck (clip is 10secs)


truck_start removeaction act3; 

while {sleep  1; _fuelCount >0 } do {
_fuelCount=_fuelCount-1;
if (_fuelCount < 0) then {_fuelCount=0};

    
hintsilent format ["Jerry Can Has %1  Liters of Fuel",_fuelCount];


};

sleep _rest;

scase setvariable ["fuel",_fuel,true];

truck_start setfuel _fuel; 

titleText ["Truck refueled","PLAIN"]; 

[F2k Sel]

Hi Allanp.

Took an age to debug some of these actions.
I've changed the way the take variable works, it now changes to a value which corresponds to what actions are being used.
I'm not going to say it's sorted as there's bound to be something messing up and it needs a major clean up.

What I think I've fixed.

Getting kicked when fuel attached to truck.
All options removed when getting in vehicle.
All options removed when refuelling.
Fuel amounts now work correctly. (you hadn't passed _fuelcount to setvariable)

I've removed the truck startup eventhandlers and they're applied when you drop a can near to the truck.

I've done it as a download, pasting it gets tedious.

See how you go.

http://www.sendspace.com/file/hvqc8x

[Allanp]

Allo F2k Sel,
Did a really quick run-through after work and I found out if you attach the fuel can and then drop it in range to refuel it starts creating multiple instances of the "Refuel Truck" action if the player hadn't already refueled. I noticed in case 4 there was another instance of refuel truck being created so I removed it (not sure if it was there for testing reasons?) but it seemed to have fixed it. I also fixed the if statements. I forgot proof read over it and left out an = (>=5)sign on feels somewhat full.

 _fuelCount = _fuel;
        if (_fuel >=1) then {_fuelCount=10; _fuel=1};
        if (_fuel > 0 and _fuel < 1) then {_fuelCount=_fuel*10};
        if (_fuel == 10) then { titleText ["This feels full","PLAIN",0.3]};
        if (_fuelCount >=5 and _fuelCount < 10) then {titleText ["This  feels somewhat full","PLAIN",0.3]};
        if (_fuelCount >=3 and _fuelCount < 5 ) then {titleText ["This feels half way full","PLAIN",0.3]};
        if (_fuelCount >=1 and _fuelCount < 3 ) then {titleText ["This feels close to empty","PLAIN",0.3]};
        if (_fuel == 0) then {titleText ["This feels empty","PLAIN"]}; 

I also refined some of the timing and added a few sounds. I'm really enjoying how this script is turning out. I looked through the Arma2 scripting references and jotted down a few more ideas.

[F2k Sel]

Cheers Allanp it's hard to test every aspect every time you make a change. I'll take another look, the script is poorly written to be honest that's why we keep getting multiple actions.

I'm trying to come up with a solution for scase and truck_start, I'd rather not use specific names for objects but that will take a while as it needs a complete re-write.
Currently I've re-written carry.sqf where as long as an object type is in the list you can carry it in either hand or on hip.
I'm just stuck on the in out car trigger. It keeps kicking me when I've dropped items.

A few ideas for the current script would be to add damage/hit eventhandler to the can. One shot it starts to leak, two or more it explodes. I have a script for the second it just needs the leak adding to it.
I also thought about a syphon fuel option so you could get it from abandon vehicles.


Only had a quick look today, the refuel action number was incorrect it was act5 it should be act3

[Allanp]

Cheers on the Honesty, I know it is poorly written, I only have a limited knowledge in programming. I know a bit of C# (I had fun making silly text based adventure games hah) and I started looking up on Java. I also found a few articles on cleaning up my code so fingers crossed it soaks in my Brain.

I had that thought run by about not giving specific names to objects so the script can be more general.

Some thoughts I had were:
Being able to fuel a specific amount into the vehicle (1/4 , 1/2 , 3/4 or until vehicle is full (or can is empty)) (I also like your siphon fuel idea, this could go hand in hand with that)
I also like the damage/hit eventhandles. Perhaps if the fuel is empty no explosion happens, but can leak if filled ( a way to repair?)

I took a look at your mission and saw that you had planned a way for the can to be refilled. I think I'll poke at that for a while and see what I can come up with.

[F2k Sel]

Well for limiting the amount of fuel you could do a distance check, If you move away to far refuelling stops. It should have that already and the same when filling. Repair would be possible you could drop the can and if it's damaged perform the healing action of the medic to repair it. Then just end the leak script.
I did fuel leak for a jeep.

http://www.sendspace.com/file/801ofn


I'm really stuck on my other idea, I just can't stop a script running every time I fire a new one so I end up with multiple events.

Any way here's my burning barrel script if you want to take a look, it may give you some ideas. It will need scaling down for a fuel can and sound needs to be set up for multiplayer.

http://www.sendspace.com/file/p3lcr7

If you can rip anything from them do so.