Detecting action?

[VanhA-ICON]

Hi huys.
The problem:
Is there a way to detect in a script if player already has certain action added?

The issue comes up when I reassign satellite view via norrins revive script.
It works of course but if an AI unit revives another unit or I revive someone I get added additional "Sat view" action.
The additional ones get deleted when I use the action so it's not a big deal but still a bit annoying.

I wish there was an "hasAction" command for this...
The satView sqf:

if ((vehicle player == player) && (local player)) then {player addAction ["Sat view", "Sat_Cam\SatellitenBild.sqf"];};
if true exitWith {};

[Shuko]

You could use set/getvariable to toggle a boolean (true/false) for each unit. :/

[VanhA-ICON]

Well, this does not work but am I getting even close?

_hasIt = false;
_hasAction = [];
while {true} do
{
if (alive player) then
{
_hasAction = player getVariable "ACT";
}
};
if true exitWith {};
else
{
if ((vehicle player == player) && (local player)) then {player addAction ["Sat view", "Sat_Cam\SatellitenBild.sqf"];};
player setVariable ["ACT",_hasAction, true];
_hasIt = true;
};
if true exitWith {};

[Celery]

player setVariable ["ACT", true, true]; when adding the action should be enough. You can check whether he has the action with if (!isNull (unit getVariable "ACT")) then ...

If the variable hasn't been added, it will be null. If the variable isn't null, you'll know that the action is there.

[andersson]

Im not sure but I think its a good idea to move the first if true exitwith {}; inside the if brackets. I believe the script is exiting now regardless if player is alive or not.

if (alive player) then
{
_hasAction = player getVariable "ACT";
if true exitWith {};
};
};
else 
{

+ your missing one ;

Took me some time but now I have managed to get 2 pieces of Grandiosa in me without loosing them

[Deadfast]

player setVariable ["ACT", true, true]; when adding the action should be enough. You can check whether he has the action with if (!isNull (unit getVariable "ACT")) then ...

If the variable hasn't been added, it will be null. If the variable isn't null, you'll know that the action is there.

It won't be null, it will be nil.

if ((vehicle player == player) && (local player) && isNil{player getVariable "TAG_satAction"}) then
{
     player setVariable["TAG_satAction", player addAction ["Sat view", "Sat_Cam\SatellitenBild.sqf"]];
}; 

@OP: there is no point in using exitWith in the context you do. SQF scripts terminate automatically once end of the file is reached.

[Celery]

It won't be null, it will be nil.

A nonexistent getVariable returns null.

[Deadfast]

A nonexistent getVariable returns null.

No, it doesn't. Just like any other variable it is nil and the condition will be skipped due to undefined variable (wish this would be considered an error).

[VanhA-ICON]

Thank you all for your effort!

Here it is at the moment, but..

_hasIt = false;
_hasAction = [];
while {true} do
{
if (alive player) then
{
_hasAction = player getVariable "ACT";
if true exitWith {};
};
};
else
{
if ((vehicle player == player) && (local player) && isNil{player getVariable "ACT"}) then
{
     player setVariable["ACT", player addAction ["Sat view", "Sat_Cam\SatellitenBild.sqf"]];
_hasIt = true;
};  
};

It's still saying that it's missing a ";" in

#else

[Celery]

No, it doesn't. Just like any other variable it is nil and the condition will be skipped due to undefined variable (wish this would be considered an error).

Go to the editor, place a player unit and put hintSilent format ["%1",player getVariable "lol"] in its init and see what it returns.

Edit: never mind, it returns <null> but responds only to isNil.